[3.x] fix unit tests MSSQL (Windows)#359
Merged
richard67 merged 1 commit intojoomla-framework:3.x-devfrom Feb 17, 2026
Merged
Conversation
Contributor
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Currently, dependencies that may be incompatible with the php version are being installed during the
MSSQL (win)tests.In this particular case, doctrine/instantiator is required by phpunit, which causes the error for php 8.1 and 8.2.
Here is the relevant commit which requires a newer php version doctrine/instantiator@21dcb5f
The new syntax requires php 8.3 https://www.php.net/releases/8.3/en.php#typed_class_constants
So, as at the other tests, we should use
composer updateinstead ofcomposer install --ignore-platform-reqs.Testing Instructions
unit tests
Documentation Changes Required
no