Add isGILEnabled Java method#218
Open
jmao-denver wants to merge 2 commits intojpy-consortium:masterfrom
Open
Conversation
cpwright
approved these changes
Jan 12, 2026
devinrsmith
reviewed
Jan 12, 2026
Comment on lines
+173
to
+174
| // The sys._is_gil_enabled() function is the documented, stable way to check GIL status from both | ||
| // Python code and C extensions in Python 3.13+ free-threaded builds. |
Member
There was a problem hiding this comment.
I don't think this is quite true. The documentation at https://docs.python.org/3/library/sys.html#sys._is_gil_enabled says:
CPython implementation detail: It is not guaranteed to exist in all implementations of Python.
In general, I think the _ prefix in a context like this means it's not part of the stable API.
I do think we should strive to work with other implementations of Python.
That said, as you mention, it's possible that python doesn't provide a stable way to call this from C API yet.
I think we should at least note we'd prefer to call stable C API here, and create a follow-up in the future (/ link to our issue / link to c python issue).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #217