excludes added to remove labs excluded from JHS#1
Open
bobtherriault wants to merge 1 commit intojsoftware:masterfrom
Open
excludes added to remove labs excluded from JHS#1bobtherriault wants to merge 1 commit intojsoftware:masterfrom
bobtherriault wants to merge 1 commit intojsoftware:masterfrom
Conversation
excludes is based on excludes_jlab805_ defined in addons/labs/labs/lab805.ijs. When used with getlabs it ensures that all the selectable labs will be able to run in JHS as the ones excluded by exlabs.txt in addons/labs/labs will have been removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
excludes is based on excludes_jlab805_ defined in addons/labs/labs/labs805.ijs. When used with getlabs it ensures that all the selectable labs will be able to run in JHS as the ones excluded by exlabs.txt in addons/labs/labs will have been removed.
Without this change, labs written in the new style will not have excluded files removed. Old style labs do have excluded files removed because they are run through the scripts of labs805.ijs