added listen function for simple node#2
Open
JushBJJ wants to merge 2 commits intokarpathy:mainfrom
JushBJJ:crypto-repo
Open
added listen function for simple node#2JushBJJ wants to merge 2 commits intokarpathy:mainfrom JushBJJ:crypto-repo
JushBJJ wants to merge 2 commits intokarpathy:mainfrom
JushBJJ:crypto-repo
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There could also be times where the node is contacted from the outside world. Although I'm not sure if binding the socket to a public ip would be suitable for this repo, so I went for the local ip address.
Also added SimpleNode.connect command so its optional whether to either listen or connect to an address, however connecting will only require the host address because of self.port already configured in the SimpleNode
__init__()arguments.