Skip to content

Addressing compiler warning: comparing a pointer to a null character constant #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonasbn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Addressing compiler warning: comparing a pointer to a null character constant #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b2f964
Addressed compiler warning: comparing a pointer to a null character c…
jonasbn Jan 25, 2025
e33c6b0
Updated PR, since I had been a tad too fast for my own good submittin…
jonasbn Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ void set_default_handler(NSString *url_scheme, NSString *handler) {
}

int main(int argc, const char *argv[]) {
const char *target = (argc == 1) ? '\0' : argv[1];
NSString *target = (argc > 1) ? [NSString stringWithUTF8String:argv[1]] : nil;

@autoreleasepool {
// Get all HTTP handlers
Expand All @@ -52,17 +52,17 @@ int main(int argc, const char *argv[]) {
// Get current HTTP handler
NSString *current_handler_name = get_current_http_handler();

if (target == '\0') {
if (target == nil) {
// List all HTTP handlers, marking the current one with a star
for (NSString *key in handlers) {
char *mark = [key caseInsensitiveCompare:current_handler_name] == NSOrderedSame ? "* " : " ";
printf("%s%s\n", mark, [key UTF8String]);
}
} else {
NSString *target_handler_name = [NSString stringWithUTF8String:target];
NSString *target_handler_name = target;

if ([target_handler_name caseInsensitiveCompare:current_handler_name] == NSOrderedSame) {
printf("%s is already set as the default HTTP handler\n", target);
printf("%s is already set as the default HTTP handler\n", [target UTF8String]);
} else {
NSString *target_handler = handlers[target_handler_name];

Expand All @@ -71,7 +71,7 @@ int main(int argc, const char *argv[]) {
set_default_handler(@"http", target_handler);
set_default_handler(@"https", target_handler);
} else {
printf("%s is not available as an HTTP handler\n", target);
printf("%s is not available as an HTTP handler\n", [target UTF8String]);

return 1;
}
Expand Down