-
Notifications
You must be signed in to change notification settings - Fork 21
feat: add Playwright E2E testing infrastructure with tree listing #1674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WilsonNet
wants to merge
1
commit into
main
Choose a base branch
from
feat/playwright
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+346
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8e9951 to
425912a
Compare
676fb72 to
af73aa6
Compare
39e3bf0 to
78202a5
Compare
59d88ee to
a60819a
Compare
- Add Playwright configuration and test framework - Create e2e tests for tree listing page with proper selectors - Set up strict TypeScript configuration for e2e tests - Add e2e commands to package.json and update scripts - Update .env.example with staging environment as default - Add comprehensive e2e documentation to README - Add Playwright artifacts to .gitignore - Update ESLint and TypeScript configs to support e2e tests - Add vitest config to exclude the e2e folder - Add dotenv - Add a few test-id selectors This establishes a complete E2E testing infrastructure using Playwright with staging as the default test environment, strict TypeScript settings, and proper documentation for developers.
a60819a to
ec2ca73
Compare
| # - Production: https://dashboard.kernelci.org | ||
| # - Local: http://localhost:5173 | ||
|
|
||
| # Install Playwright browsers if you don't have them them |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| # Install Playwright browsers if you don't have them them | |
| # Install Playwright browsers if you don't have them yet |
| await originDropdown.click(); | ||
|
|
||
| await expect( | ||
| page.locator(COMMON_SELECTORS.originOption('linaro')), |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling that relying on a fixed name for the tests is not the best move, it could change and break the tests... but for now I think it's ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive Playwright E2E testing infrastructure to the dashboard project. The implementation includes:
Changes
🔧 Framework Setup
playwright.config.tswith environment supporttsconfig.e2e.json🧪 Test Implementation
basic.spec.tstotree-listing.spec.tse2e-selectors.ts) with robust element selectors📋 Configuration & Environment
package.jsonwith singlee2ecommand ande2e-uicommand.env.example🗂️ Git Management
test-results/,playwright-report/) to.gitignoreBenefits
Usage