-
Notifications
You must be signed in to change notification settings - Fork 7
GetData-0.12.0 release #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This PR stacks on the previous one (#21), and I am expecting them to be merged in sequence and possibly squashed along the way. Please comment here on "release ceremony" (version number, ChangeLog/README updates, et cetera). When/if #21 gets merged, squashed, or rebased, I will graft this PR onto whatever results. |
e232ca7 to
e497c9d
Compare
arahlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks complete to my eye. Will give @ketiltrout a bit of time to comment in case there's anything to add here.
|
Turns out that Windows lacked some plugin support due to the CI/CD environment. I am preparing another PR to bring Windows up to a minimum baseline (including a Python test script to check automatically), and will rebase this PR on top of it once it's complete. |
This appears to be a gcc extension that msvc does not allow. Because we didn't build the lzma code on Windows before this, it didn't matter.
e497c9d to
240f141
Compare
|
I have added the necessary commits to this PR (before the RELEASE commit). Once the build completes without errors, I think we're clear to merge. |
240f141 to
fee6aee
Compare
These tests were accidentally bypassed due to a macro typo.
fee6aee to
24c08c9
Compare
|
Along the way, I found a couple of goofs:
These are now fixed. As above - when the CI/CD tests run to completion (this time for sure!) we are OK to merge. |
24c08c9 to
d2fd3ff
Compare
Notably, Windows does not always have gunzip, and the conditional logic associated with running tests did not correctly handle environments with gzip but not gunzip. I've modified bunzip2/bzip2 for consistency.
This release adds support for building Python wheels via CMake and scikit-build-core, enabling cross-platform builds for Windows, Linux, and macOS. Python bindings now require Python 3.9+ and support NumPy 2.x. Build system improvements: - CMake modernization for Python wheel generation and improved cross-platform compatibility - Added CI/CD workflows for automated testing on Ubuntu, macOS, and Windows platforms via GitHub Actions - Improved MSVC (Visual C++) compatibility for native Windows builds Python bindings: - Updated to support NumPy 2.x - Fixed encoding_support return codes - Improved Python 3.x compatibility in test suite (exception handling, path separators, regex handling for builds without PCRE support) Compatibility fixes: - Fixed 64-bit time_t compatibility on 32-bit architectures - Fixed Python version detection for Python 3.10+ - Updated Fortran support for modern gfortran (>= 10) with -std=legacy and -fallow-argument-mismatch flags - Fixed MacOS .dylib generation and post-install path demangling - Bumped minimum automake version to 1.16
d2fd3ff to
ac0c961
Compare
|
And, finally, two more Windows fixes
I am pleased to see all tests pass now. @arahlin, @ketiltrout, my apologies for the avalanche of GitHub e-mails you've been receiving. If you want the complete summary, it's all captured in my comments on the PR. The current commit stack is logical (and you can either merge it as-is, or squash, as you prefer). Please merge at your leisure (or let me know if you would like to see any more changes.) |
This release adds support for building Python wheels via CMake and scikit-build-core, enabling cross-platform builds for Windows, Linux, and macOS. Python bindings now require Python 3.9+ and support NumPy 2.x.
Build system improvements:
Python bindings:
Compatibility fixes: