Update adding-new-translation-messages-or-changing-the-default-ones.md#48
Update adding-new-translation-messages-or-changing-the-default-ones.md#48Popovkov57 wants to merge 1 commit intokeycloakify:v11from
Conversation
Update of function naming
WalkthroughThe documentation was updated to replace references to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
features/i18n/adding-new-translation-messages-or-changing-the-default-ones.md (2)
117-120: Consider adding the recommendedadvancedMsgStr()call right after themsgStr()example.The snippet correctly demonstrates that
msgStr("profile.attributes.favourite_pet")compiles but produces a TS error. However, the immediate follow-up example usingadvancedMsgStr()is buried in the prose below. Adding it beside themsgStr()call would make the contrast crystal-clear for readers skimming the doc.msgStr("profile.attributes.favourite_pet"); + +// type-safe alternative +advancedMsgStr("profile.attributes.favourite_pet");
122-123: Minor grammar tweak — “some place” → “some places”.-This is why you'll see in some place in the code the usage of `advancedMsgStr(attribute.displayName)`, +This is why you'll see in some places in the code the usage of `advancedMsgStr(attribute.displayName)`,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
features/i18n/adding-new-translation-messages-or-changing-the-default-ones.md(1 hunks)
Update of function naming. Close #49
Summary by CodeRabbit