perf: Improve time complexity for find_or_add#14
Draft
kdy1 wants to merge 2 commits intokhonsulabs:mainfrom
Draft
perf: Improve time complexity for find_or_add#14kdy1 wants to merge 2 commits intokhonsulabs:mainfrom
find_or_add#14kdy1 wants to merge 2 commits intokhonsulabs:mainfrom
Conversation
kdy1
changed the title
find_or_add_strfind_or_add
| @@ -649,40 +651,36 @@ impl SymbolMap { | |||
| // address of the str in the map. | |||
| let symbol_address = symbol.as_ptr() as usize; | |||
| // Perform a binary search to find this existing element. | |||
| let id = entries.len() as u32; | ||
| let start = symbols.len(); | ||
| symbols.push_str(symbol); | ||
| entries.insert(insert_at, (start..symbols.len(), id)); |
There was a problem hiding this comment.
wont you have the same 'insert' concern here? whenever we insert a new static string via find_or_insert we should also be inserting a new string here (since I'm pretty sure the rust compiler deduplicates string constants).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In turbopack, we serialize some large types using
pot. The time complexity of addition isO(log N)for lookup andO(N)for insertion. I want to check if it is possible to improve it.