perf(luaJIT): use LuaJIT stringbuffers, if present. Fixes #67#78
Merged
perf(luaJIT): use LuaJIT stringbuffers, if present. Fixes #67#78
Conversation
Owner
Author
|
LuaJIT CI Perf results in master (no stringbuffers): LuaJIT CI Perf results on this branch (string buffers active):
Overall there's a significant performance increase on all non-trivial scenarios. |
d63083f to
07b3dd8
Compare
Owner
Author
|
Running this on github's CI servers is really not reliable so I'll try to set things locally and run the perf tests several times before merging. |
Owner
Author
|
Ran it locally several times and when LuaJIT has stringbuffers I saw a perf increase of ~20% for anything more complicated than an empty table or a single string. Overall, worth it. So merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.