feat: Make request parameter not needed#183
Open
rgryta wants to merge 3 commits intolaurentS:masterfrom
Open
Conversation
rgryta
changed the title
request parameter not neededrequest parameter not needed
|
Any reviewers on this? @laurentS is this still maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a project I've encountered a need to retrieve a Request object from fastapi - but didn't want to put the limitation on the user to add the Request parameter manually every single time when it's unnecessary.
As such, I've created a decorator that forces adds a
[request: Request]to the function's signature if it's not there already. Before the final function is executed - the request is removed from args/kwargs.Let me know if this is even something that people here would like to have (or not).