refactor: DRY code added for ip address

[brunolnetto]

Tests passing, removed repeated code.

[thentgesMindee]

Hi, thanks for the PR, LGTM but the CI is failing: you need to run black on your changes + there seems to be a Semantic PR check as well which I'm not completely aware of

[brunolnetto]

Buttocks. Semantic PR — ready to be squashed.

[brunolnetto]

Command run mypy is failing like below. Weird. :-(

slowapi/util.py:10: error: Item "None" of "Optional[Address]" has no attribute "host"

[laurentS]

Command run mypy is failing like below. Weird. :-(

slowapi/util.py:10: error: Item "None" of "Optional[Address]" has no attribute "host"

mypy is telling you that request.client is of type Optional[Address] so it can be None, in which case there is no attribute host on it (the last part of your line).
It looks like it's not smart enough to figure out the logic you wrote. You have 2 options (at least):

• change your code to a plain if ...
• silence mypy with a # type: ignore comment at the end of the line.

[brunolnetto]

@laurentS I fixed as suggested.

[laurentS]

@laurentS I fixed as suggested.

@brunolnetto Can you run the various checks locally before pushing? It will avoir the back and forth.

[brunolnetto]

I run command poetry run mypy ., but this error is annoying me somewhat. Do you still have any idea what I am facing?

error: Positional-only parameters are only supported in Python 3.8 and greater