Validate_password plugin#15
Open
tripplea-sg wants to merge 6 commits intolefred:masterfrom
tripplea-sg:master
Open
Validate_password plugin#15tripplea-sg wants to merge 6 commits intolefred:masterfrom tripplea-sg:master
tripplea-sg wants to merge 6 commits intolefred:masterfrom
tripplea-sg:master
Conversation
new file: validate_password/password_validation.py
Owner
|
Hi Hananto, For the next additions if any, please to a PR per plugin you are adding. This PR contains the validate password one but also the previous one (related to group_replication). That one is a bit more complicated to merge as I need to perform multiple tests as some changes have been done on some of the methods already tested. |
Author
|
Hi Lefred, Sorry for that, but I remember created 2 PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Lefred,
Please let me know if this is okay.
Thanks,
Han