Skip to content

Test #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Feb 9, 2026
Merged

Test #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions include/bitcoin/network/protocols/protocol.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@
namespace libbitcoin {
namespace network {

class stoppable
{
public:
virtual void stop(const code& ec) = 0;
virtual ~stoppable() = default;
};

/// This class is thread safe, except for:
/// * start/started must be called on strand.
/// * setters should only be invoked during handshake.
Expand All @@ -40,7 +47,8 @@ namespace network {
/// Protocol start has no failure condition.
/// A protocol can only stop its channel, not the session/network.
class BCT_API protocol
: public enable_shared_from_base<protocol>, public reporter
: public virtual stoppable,
public enable_shared_from_base<protocol>, public reporter
{
public:
typedef std::shared_ptr<protocol> ptr;
Expand Down Expand Up @@ -150,8 +158,8 @@ class BCT_API protocol
/// Channel is stopped or code set.
virtual bool stopped(const code& ec=error::success) const NOEXCEPT;

/// Stop the channel.
virtual void stop(const code& ec) NOEXCEPT;
/// Stop the channel (stoppable::stop).
void stop(const code& ec) NOEXCEPT override;

/// Pause reading from the socket, stops timers (requires strand).
virtual void pause() NOEXCEPT;
Expand Down
Loading