Add Repository.load_filter_list, FilterList #1444
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the main git_filter_list features in libgit2.
Important note:
filter_unregisteralready exists in pygit2. Unregistering a filter while it's still in use in a FilterList would cause undefined behavior in libgit2. To prevent this,filter_unregisterchecks that the filter isn't in use in any live FilterLists before proceeding - otherwise, it raises RuntimeError. (To do so, I moved the implementation forfilter_unregisterfrom C to Python.)