Update Event::PaymentReceived docs since we require payment secret#1079
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Oct 5, 2021
Merged
Conversation
valentinewallace
approved these changes
Sep 17, 2021
Codecov Report
@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
- Coverage 91.01% 90.99% -0.02%
==========================================
Files 65 65
Lines 33767 33767
==========================================
- Hits 30732 30727 -5
- Misses 3035 3040 +5
Continue to review full report at Codecov.
|
valentinewallace
approved these changes
Sep 17, 2021
arik-so
approved these changes
Oct 5, 2021
Users no longer need to verify the amounts of received payments as the payment secret will protect us against the probing attacks such verification was intended to fix.
d7d7801 to
7478207
Compare
Collaborator
Author
|
Squashed without change, will land after CI: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users no longer need to verify the amounts of received payments as
the payment secret will protect us against the probing attacks such
verification was intended to fix.
Reported at getlipa/ldk-sample-java#1 (comment)