-
Notifications
You must be signed in to change notification settings - Fork 67
Restored rag_chunks attribute in query response #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restored rag_chunks attribute in query response #1029
Conversation
WalkthroughThe pull request adds RAG chunk metadata to API responses by introducing a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/openapi.json`:
- Around line 7651-7658: The OpenAPI schema for the property "rag_chunks" is
marked deprecated only in its description; update the schema to include explicit
OpenAPI deprecation metadata by adding "deprecated": true to the rag_chunks
array schema (the property named "rag_chunks" that references
"#/components/schemas/RAGChunk"); apply the same change to the other occurrence
of the rag_chunks property found elsewhere in the document so tooling recognizes
it as deprecated.
🧹 Nitpick comments (1)
docs/openapi.json (1)
7976-8014: Consider locking downRAGChunkshape.
Most schemas here useadditionalProperties: false; adding it would keep the contract consistent and prevent silent payload drift.♻️ Suggested tweak
"RAGChunk": { + "additionalProperties": false, "properties": { "content": { "type": "string", "title": "Content", "description": "The content of the chunk" },
tisnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR restores the original
rag_chunksattribute in query response and marks it as deprecated. It also fixes source attribute parsing in rag chunk object.Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit
rag_chunksfield to API responses (marked deprecated; usetool_resultsinstead).tool_resultsfield to query responses for improved tool interaction transparency.✏️ Tip: You can customize this high-level summary in your review settings.