feat: update Dockerfile to make chown command faster#42
Open
AbijahKaj wants to merge 1 commit intolivekit-examples:mainfrom
Open
feat: update Dockerfile to make chown command faster#42AbijahKaj wants to merge 1 commit intolivekit-examples:mainfrom
AbijahKaj wants to merge 1 commit intolivekit-examples:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the Dockerfile build process by optimizing file ownership handling and enhancing security. The main changes focus on setting file ownership during the copy steps and reducing the need for later permission adjustments (which usually take around 100 seconds in my tests, now this is reduced to near 0.5 seconds).
Dockerfile improvements:
--chown=appuser:appuserduringCOPYcommands to set file ownership immediately, reducing the need for separatechowncommands and improving build speed.appuseruser before installing Python dependencies to avoid post-installation permission fixes.USERcommands to ensure files are copied and owned correctly, then switched back to a non-privileged user for security.