Skip to content

Include current app in macOS screen share #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hiroshihorie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Include current app in macOS screen share #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Multiplatform/Controllers/RoomContext.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ final class RoomContext: ObservableObject {
@available(macOS 12.3, *)
func setScreenShareMacOS(isEnabled: Bool, screenShareSource: MacOSScreenCaptureSource? = nil) async throws {
if isEnabled, let screenShareSource {
let track = LocalVideoTrack.createMacOSScreenShareTrack(source: screenShareSource)
let track = LocalVideoTrack.createMacOSScreenShareTrack(source: screenShareSource, options: ScreenShareCaptureOptions(includeCurrentApplication: true))
let options = VideoPublishOptions(preferredCodec: VideoCodec.h264)
screenShareTrack = try await room.localParticipant.publish(videoTrack: track, options: options)
}
Expand Down
4 changes: 2 additions & 2 deletions Multiplatform/Views/ScreenShareSourcePickerView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ import SwiftUI
}
}

let sources = try await MacOSScreenCapturer.sources(for: mode == .display ? .display : .window)
let options = ScreenShareCaptureOptions(dimensions: .h360_43, fps: 5)
let sources = try await MacOSScreenCapturer.sources(for: mode == .display ? .display : .window, includeCurrentApplication: true)
let options = ScreenShareCaptureOptions(dimensions: .h360_43, fps: 5, includeCurrentApplication: true)
let _newTracks = sources.map { LocalVideoTrack.createMacOSScreenShareTrack(source: $0, options: options) }

Task { @MainActor in
Expand Down