Closed
Conversation
Contributor
Author
|
Note: Navigare reports he has used this build and it resulted in memory leaks. I don't see an apparent cause for this, but a point to keep in mind for the review. Might be missing something (like maybe it is something stupid like how I probe the input size) |
3771207 to
d17b16b
Compare
Contributor
Author
|
Closed, in favour of #438 which targets the root cause |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Note: technically the check for negative timestamps should be enough, but included the other one as well. We could also omit it.