-
Notifications
You must be signed in to change notification settings - Fork 135
Fix: Languages changed when opening a dispute #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mostronator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅ Clean fix for #553. The core issue was that dispute messages to both parties used ctx.i18n (the initiator's language context) instead of each user's own language.
The getDisputeParties helper properly resolves i18n contexts per user via getUserI18nContext(). Messages to the counterparty and to buyer/seller in disputeData now use their respective language contexts.
One minor observation: getDisputeParties calls getUserI18nContext 3 times — once for buyer, once for seller, and once for counterParty. Since counterParty is always one of buyer/seller, the third call is redundant. Not a blocker, but could be simplified.
Good fix, resolves #553.
@Matobi98 can you address this comment? |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Fix: Dispute messages now respect each user's language
Problem
When users involved in a dispute had different bot languages configured, dispute-related messages were sent using the language of who triggered the action, instead of the language of each recipient.
This caused inconsistent behavior, for example:
Each user should always receive bot messages in their own configured language.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.