fix: initialize next_arg with an empty string if match[2] is unde…
#740
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the commandArgs middleware where commands sent without arguments resulted in the first argument being the literal string
"undefined".Root Cause
The
RegExp.prototype.exec()method expects a string. When no arguments were present,match[2]wasundefined. JavaScript coerced thisundefinedvalue into the string"undefined", which was then matched as a valid argument by the secondary regex.Changes
''ifmatch[2]is null/undefined.Summary by CodeRabbit