fix: correct FTBFS for Android#38
Conversation
There was a problem hiding this comment.
The first commit looks good to me but 641a245 probably won't work as you expected.
The reason the user has to insert lua-https as part of their compilation in LOVE 11.5 because lua-https requires additional Java files to be compiled inside the LOVE itself. This inclusion of Java files is automatically handled by LOVE build.gradle as long as you put lua-https properly in the specified folder. Cherry-picking https.so into prebuilt binary of your custom LOVE APK is not sufficient to make lua-https work in Android.
To prevent misleads, can you remove that particular commit? Thanks.
|
@MikuAuahDark I can (and will) remove that commit, but can you help educate me before I do? I'm new to building Android apps. Android builds of my LOVE 11.5 demo have the architecture-specific versions of I've worked around this by bundling the I want to be sure I'm using https correctly with LOVE 11.5 because I use the same pattern for Linux, Windows, and macOS. |
|
You have to be careful with that approach as Android 10 and later doesn't allow that workaround (save directory is writable but you can't load any .so in save directory). It should able to find them as long as you follow the approach. If it cannot find Furthermore, even if you able to load |
641a245 to
218554b
Compare
|
Thanks for the insight @MikuAuahDark I've dropped the commit that adds the Android artifact collection. |
This pull request adds the missing
UnixLibraryLoader.cpptoAndroid.mkso that it links successfully.I found the pre-builthttps.soartifacts for other platforms useful, so I've added a GitHub workflow job to attach Androidhttps.soartifacts during CI builds. As lua-https is bundled in LÖVE 12.0 by default, the workflow I've added builds against LÖVE 11.5a for Android.