Feature: Add Option for CMAKE_POSITION_INDEPENDENT_CODE#41
Open
TurtleP wants to merge 2 commits intolove2d:mainfrom
Open
Feature: Add Option for CMAKE_POSITION_INDEPENDENT_CODE#41TurtleP wants to merge 2 commits intolove2d:mainfrom
TurtleP wants to merge 2 commits intolove2d:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the project enforces a default of
CMAKE_POSITION_INDEPENDENT_CODEtoON. Normally, this is not a problem, except in instances where-fPICis not supported. In my case, compiling this for Wii U homebrew nets me compilation failure (see this GitHub issue. This pull request allows people to define-DHTTPS_USE_FPICwhen invoking CMake orset(HTTPS_USE_FPIC OFF CACHE BOOL "Disable PIC for lua-https" )before adding the project to set whether it is to be used. Doing so has allowed for my Wii U homebrew to compile successfully.