class Memory: allow to set default simulate value for all generated memory blocks.#268
Open
Fatsie wants to merge 1 commit intom-labs:masterfrom
Fatsie:memory_defsimulate
Open
class Memory: allow to set default simulate value for all generated memory blocks.#268Fatsie wants to merge 1 commit intom-labs:masterfrom Fatsie:memory_defsimulate
simulate value for all generated memory blocks.#268Fatsie wants to merge 1 commit intom-labs:masterfrom
Fatsie:memory_defsimulate
Conversation
… memory blocks. If `simulate` parameter passed to `Memory.__init_()` is None the class `simulate` value will be used.
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
==========================================
- Coverage 82.07% 82.07% -0.01%
==========================================
Files 34 34
Lines 5597 5600 +3
Branches 1200 1201 +1
==========================================
+ Hits 4594 4596 +2
Misses 863 863
- Partials 140 141 +1
Continue to review full report at Codecov.
|
Contributor
|
I'm rewriting the simulator right now so that it would not need the (expensive) memory lowering. So I'll keep this open, with the understanding that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have nmigen code mixed with other RTL language code so am using external simulator. With this option I can now turn off the memory preparation for pysim for all generated blocks.