Add variable keyword argument support to nmigen.hdl.rec.Record#339
Open
DonaldKellett wants to merge 1 commit intom-labs:masterfrom
DonaldKellett:master
Open
Add variable keyword argument support to nmigen.hdl.rec.Record#339DonaldKellett wants to merge 1 commit intom-labs:masterfrom DonaldKellett:master
DonaldKellett wants to merge 1 commit intom-labs:masterfrom
DonaldKellett:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows additional keyword arguments to be specified and passed to
Signals when constructing aRecord. All 546 existing tests pass after the change, so the changes should be fully backwards compatible.