Added firefox & IE support + fixed callback not firing.#9
Open
gijsroge wants to merge 6 commits intomadebysource:masterfrom
Open
Added firefox & IE support + fixed callback not firing.#9gijsroge wants to merge 6 commits intomadebysource:masterfrom
gijsroge wants to merge 6 commits intomadebysource:masterfrom
Conversation
gijsroge
commented
May 22, 2015
- This will add support for Firefox and Internet Explorer.
- Add a check if scroll reached bottom page to trigger callback
This was referenced May 22, 2015
Author
|
Note: removed the hardcoded fix for scrolling with the body element. You should include this polyfill to fix the issue -> https://github.com/mathiasbynens/document.scrollingElement |
|
Why was this never merged? Does it still work? |
Author
|
@derek-schultz Probably because they are busy which is perfectly reasonable, in the mean time you can use my fork. https://github.com/gijsroge/animated-scrollto |
|
@gijsroge I used your repository as replacing NPM package of this one, but it still does not work on FF |
Author
|
@nikoloza Did you add the scollingElement polyfill? See: https://github.com/gijsroge/animated-scrollto#browser-support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.