Conversation
andrewharvey
left a comment
There was a problem hiding this comment.
This is great thanks, looks like just needs a rebase against main to rebuild the docs.
|
Hey there! Any chance this could get merged and a new version deployed? I could really use this in a current project. If any help is needed to get this merged I would be happy to help out. Thanks! |
|
This would be a valuable addition for me. Can we get this in? |
9283b82 to
80bef3b
Compare
80bef3b to
2d05657
Compare
|
rebased against main with rebuilt docs |
I think best to leave it as
Definitely a separate method sounds best to me, as it mirrors the main API and the method name is immediately clear on what it does. |
|
Can we please get this merged in. |
This adds the
Tilesets.replaceTilesetSourcemethod to the Tilesets service. https://docs.mapbox.com/api/maps/#replace-a-tileset-sourceI'm reading through the development requirements, and think I need to verify a few things:
put*, so should I rename this toTilesets.putTilesetSource? Happy to change it!replace: trueoption toTilesets.createTilesetSourcemethod instead of an entirely new method. This would effectively change POST to PUT, but I wasn't able to find any instances of this pattern in the rest of the SDK. Thoughts on this idea?Also massive h/t to @andrewharvey for adding the Tilesets service to the SDK originally. So good!
cc @katydecorah @andrewharvey
closes #432