Open
Conversation
- Use useOptionalBoardProvider in TickAction and LogAscentForm so playlist pages without BoardProvider don't crash - Simplify LogAscentForm saveTick fallback using spread + executeGraphQL - Remove cross-layout climb filtering that incorrectly hid playlist climbs - Add Share button to playlist hero card (visible to all users) - Hide ellipsis menu for non-owners (was opening empty) - Remove unused MuiAlert import Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use useRef for wsAuthToken so the fallback saveTick always reads the latest token value, even if it refreshes after the closure was created - Add tests for TickAction: auth fallback (with/without BoardProvider), logbook filtering by uuid+angle, badge count, action structure - Add tests for LogAscentForm saveTick logic: auth delegation, GraphQL fallback with spread, field completeness, fresh token via ref Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace manual executeGraphQL/useWsAuthToken fallback pattern with standalone useSaveTick and useLogbook hooks from cleanup_providers. This eliminates the stale token closure issue and leverages TanStack Query's caching/deduplication. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Pass empty climbUuids to useLogbook when BoardProvider is present, preventing an unnecessary network request - Add success message after native navigator.share() completes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix playlist viewing for public/non-owner playlists
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.