Fix use-external-python in the action #22
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marian-code/python-lint-annotate@fd01666 broke setting the Python version for the action. While use-external-python works in .github/workflows/test-python-install.yml, it does not work in the action itself. This is because custom action inputs cannot use true booleans, so the use-external-python input is a string type. This string then always gets interpreted as "true", so the "Setup python" condition always resolves to "false" due to negation. Use fromJSON to correctly convert the strings "true" and "false" to boolean types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fd01666 (PR #16) broke setting the Python version for the action.
While use-external-python works in .github/workflows/test-python-install.yml, it does not work in the action itself. This is because custom action inputs cannot use true booleans, so the use-external-python input is a string type. This string then always gets interpreted as "true", so the "Setup python" condition always resolves to "false" due to negation.
Use fromJSON to correctly convert the strings "true" and "false" to boolean types.
To compare, see these before and after logs, paying special attention to the Python version in each job:
Please note that the action test will "fail" until #21 is merged because the macos-13 runners cannot initialize.