This repository was archived by the owner on Nov 25, 2024. It is now read-only.
Open
Conversation
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3432 +/- ##
==========================================
- Coverage 68.34% 68.32% -0.02%
==========================================
Files 513 513
Lines 47026 47026
==========================================
- Hits 32138 32129 -9
- Misses 10896 10900 +4
- Partials 3992 3997 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
S7evinK
approved these changes
Sep 22, 2024
Contributor
S7evinK
left a comment
S7evinK
left a comment
There was a problem hiding this comment.
Again, something I wanted to do for a long time :D So thanks!
| mark_as_latest: false | ||
|
|
||
| invoke_pages_build: | ||
| runs-on: ubuntu-latest |
Contributor
There was a problem hiding this comment.
I think we need a needs: [ release ], as otherwise this might run concurrently with the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that newly released charts don't appear immediately until I manually run the
gh-pagesworkflow - Lets see if we can dispatch that on a release eventPull Request Checklist
Signed-off-by:
Rhea Danzey <rdanzey@element.io>