Emit full 'IVectorMethods' types for lists in 'cswinrtgen' #2166
+462
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the SetAt method logic for IList<T> to InteropMethodDefinitionFactory.IVectorMethods, replacing the previous placeholder implementation. This centralizes method creation and provides a complete method body for SetAt, improving maintainability and consistency.
Introduces a shared SetAtOrInsertAt helper to generate both SetAt and InsertAt methods for IVector<T> interfaces, reducing code duplication and improving maintainability. Updates method body construction to use the new helper and parameterize method name and signature.
Moves InsertAt method definition logic from InteropTypeDefinitionBuilder.IList1 to InteropMethodDefinitionFactory.IVectorMethods. This centralizes method creation and reduces duplication, improving maintainability.
Moved the construction of the IList<T>.Append method to InteropMethodDefinitionFactory.IVectorMethods.Append, providing a full method body and parameter marshaling logic. This improves maintainability and consistency with other interop method definitions.
Refactored IList<T> interop builder to use a new InteropMethodDefinitionFactory.IVectorMethods.IndexOf method, which now provides a full implementation for the IndexOf method, including method body and parameter marshaling. This improves maintainability and consistency with other IVector methods.
Updated the XML documentation for CilOutParameterIndices to clarify that parameter indices are 1-based, with index 0 representing the implicit 'this' parameter.
There was a problem hiding this comment.
Pull request overview
This PR implements full code generation for IVectorMethods types in the cswinrtgen tool. Previously, these methods had placeholder implementations that threw exceptions; now they generate complete CIL method bodies with proper marshalling, exception handling, and resource cleanup.
Key changes:
- Adds factory methods for generating
SetAt,InsertAt,Append, andIndexOfimplementations - Implements proper try/finally blocks for resource cleanup
- Handles parameter marshalling with native type conversion
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
InteropMethodDefinitionFactory.IVectorMethods.cs |
New file containing factory methods for generating complete IVector<T> method implementations with CIL bodies |
MethodDefinitionExtensions.cs |
Added documentation clarifying that CilOutParameterIndices uses 1-based indexing |
InteropTypeDefinitionBuilder.IList1.cs |
Replaced placeholder method stubs with calls to the new factory methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // Track rewriting the 'value' parameter for this method | ||
| emitState.TrackNativeParameterMethodRewrite( | ||
| paraneterType: elementType, |
There was a problem hiding this comment.
Corrected spelling of 'paraneterType' to 'parameterType'.
Suggested change
| paraneterType: elementType, | |
| parameterType: elementType, |
|
|
||
| // Track rewriting the 'value' parameter for this method | ||
| emitState.TrackNativeParameterMethodRewrite( | ||
| paraneterType: elementType, |
There was a problem hiding this comment.
Corrected spelling of 'paraneterType' to 'parameterType'.
Suggested change
| paraneterType: elementType, | |
| parameterType: elementType, |
|
|
||
| // Track rewriting the 'value' parameter for this method | ||
| emitState.TrackNativeParameterMethodRewrite( | ||
| paraneterType: elementType, |
There was a problem hiding this comment.
Corrected spelling of 'paraneterType' to 'parameterType'.
Suggested change
| paraneterType: elementType, | |
| parameterType: elementType, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.
Examples of codegen:
Note
Draft because there's some commits to move and this branch also needs to be rebased.