Skip to content

Removed gpsbabel from SPECS-EXTENDED and removed its dependency in gdal, updated minizip-ng and freexl dependency issue #15482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
v-aaditya wants to merge 0 commits into from
Closed

Removed gpsbabel from SPECS-EXTENDED and removed its dependency in gdal, updated minizip-ng and freexl dependency issue #15482

v-aaditya wants to merge 0 commits into from

Conversation

@v-aaditya
Copy link
Contributor

@v-aaditya v-aaditya commented Jan 12, 2026 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary
  • Removed gpsbabel package from SPECS-EXTENDED
  • Removed gpsbabel dependency from gdal and removed "test-unit" test case from gdal as it was getting failed.
  • Rebuilt minizip-ng package to build "minizip-compat-devel" which is needed by "freexl" package.
  • Updated dependency package name in "freexl" to "minizip-compat-devel" as the "minizip" package name has been renamed to "minizip-ng". Reference PR - Rename and Upgrade: minizip 2.10.1 to minizip-ng 4.0.7 #12599
Build/Dependency Information

Kindly build below dependency packages with gdal -
"blosc ilmbase uriparser CharLS cfitsio hdf libdap libgeotiff libgta libkml liblerc netcdf ogdi OpenEXR openjpeg2 proj qhull libbsd minizip-ng freexl"

Change Log
  • modified: cgmanifest.json
  • modified: LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
  • modified: LICENSES-AND-NOTICES/SPECS/data/licenses.json
  • modified: SPECS-EXTENDED/gdal/gdal.spec
  • modified: SPECS-EXTENDED/freexl/freexl.spec
  • modified: SPECS-EXTENDED/minizip-ng/minizip-ng.spec
  • deleted: SPECS-EXTENDED/gpsbabel/0002-No-solicitation.patch
  • deleted: SPECS-EXTENDED/gpsbabel/gpsbabel.png
  • deleted: SPECS-EXTENDED/gpsbabel/gpsbabel.signatures.json
  • deleted: SPECS-EXTENDED/gpsbabel/gpsbabel.spec
Does this affect the toolchain?

NO

Test Methodology
  • Local build was successful.
  • License check script shows no warning messages.

-Build logs
gdal-3.6.3-3.azl3.src.rpm.log
gdal-3.6.3-3.azl3.src.rpm.test.log

  • Installation Check
image
  • Uninstallation Check
image

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Jan 12, 2026
@v-aaditya
Copy link
Contributor Author

v-aaditya commented Jan 12, 2026

Kindly build below dependency packages with gdal -
"blosc ilmbase uriparser CharLS cfitsio hdf libdap libgeotiff libgta libkml liblerc netcdf ogdi OpenEXR openjpeg2 proj qhull libbsd minizip-ng freexl"

@v-aaditya v-aaditya marked this pull request as ready for review January 12, 2026 12:45
@v-aaditya v-aaditya requested review from a team as code owners January 12, 2026 12:45
sandeepkarambelkar
sandeepkarambelkar reviewed Jan 14, 2026
View reviewed changes
SPECS-EXTENDED/gdal/gdal.spec Outdated
Requires: %{name}-libs%{?_isa} = %{version}-%{release}
# Run time dependency for gpsbabel driver
Requires: gpsbabel
#Requires: gpsbabel
Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than commenting better to remove it.

Copy link
Contributor Author

@v-aaditya v-aaditya Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it.

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Jan 14, 2026

Buddy Build for building gdal - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1026024&view=results

@v-aaditya v-aaditya changed the title Removed gpsbabel from SPECS-EXTENDED and removed its dependency in gdal Removed gpsbabel from SPECS-EXTENDED and removed its dependency in gdal, updated minizip-ng and freexl dependency issue Jan 14, 2026
@v-aaditya
Copy link
Contributor Author

v-aaditya commented Jan 17, 2026

This PR is ready for review !

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Jan 19, 2026

Buddy Build for dependent packages - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1029680&view=results

@v-aaditya
Copy link
Contributor Author

v-aaditya commented Jan 19, 2026

Buddy Build for dependent packages - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1029680&view=results

Buddy build has failed, and there are 2 issues which are unrelated to this PR -

  • Buddy Build has failed in "Verify Test Results" phase, as liblerc package testsuite has failed.
  • License check warning in below packages which are unrelated to this PR -
    • hdf
    • libbsd
    • liblerc
    • ogdi

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Jan 19, 2026

Buddy Build to verify test execution of liblerc on 3.0-dev - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1029701&view=results

@v-aaditya
Copy link
Contributor Author

v-aaditya commented Jan 19, 2026

Buddy Build to verify test execution of liblerc on 3.0-dev - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1029701&view=results

This has also failed because the testsuite failed for liblerc package.

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Jan 19, 2026

Buddy Build to verify test execution of liblerc on 3.0-dev - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1029701&view=results

This has also failed because the testsuite failed for liblerc package.

Can you add the test fix in this PR?

@v-aaditya v-aaditya closed this Jan 19, 2026
@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Jan 19, 2026

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1029752&view=results

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Jan 19, 2026

Reopening as it got closed by mistake.

@v-aaditya
Copy link
Contributor Author

v-aaditya commented Jan 19, 2026

Accidentally closed this PR and could not reopen it. Therefore, a new PR #15525 has been created for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandeepkarambelkar sandeepkarambelkar sandeepkarambelkar left review comments

Assignees

No one assigned

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging security specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v-aaditya @sandeepkarambelkar