Remove Windows pool from build stage#1535
Conversation
Removed Windows pool configuration from build stage, since template job defines pool
DefaultRyan
left a comment
DefaultRyan
left a comment
There was a problem hiding this comment.
Please port this and the other needed changes over to OneBranch.PullRequest.yml
Prefast is enabled in the build stage template job
.pipelines/jobs/OneBranchNuGet.yml
Outdated
| inputs: | ||
| command: 'custom' | ||
| arguments: 'push $(ob_outputDirectory)\packages\Microsoft.Windows.CppWinRT.$(PackageVersion).nupkg -NonInteractive -Source https://microsoft.pkgs.visualstudio.com/_packaging/CppWinRT/nuget/v3/index.json -ApiKey VSTS' No newline at end of file | ||
| arguments: 'push $(ob_outputDirectory)\packages\Microsoft.Windows.CppWinRT.$(PackageVersion).nupkg -NonInteractive -Source https://microsoft.pkgs.visualstudio.com/_packaging/CppWinRT/nuget/v3/index.json -ApiKey VSTS -SkipDuplicate' |
There was a problem hiding this comment.
@DefaultRyan Let me know how you feel about this one
There was a problem hiding this comment.
It's an improvement, but rather than silently omitting packages from the official build just because they collide with a CI build version, let's add a pre-release version to the CI builds. This will remove the collisions so that the official build can always push, and it also clearly denotes the non-official with the pre-release identifier.
I added the code suggestion up above.
.pipelines/jobs/OneBranchNuGet.yml
Outdated
| inputs: | ||
| command: 'custom' | ||
| arguments: 'push $(ob_outputDirectory)\packages\Microsoft.Windows.CppWinRT.$(PackageVersion).nupkg -NonInteractive -Source https://microsoft.pkgs.visualstudio.com/_packaging/CppWinRT/nuget/v3/index.json -ApiKey VSTS' No newline at end of file | ||
| arguments: 'push $(ob_outputDirectory)\packages\Microsoft.Windows.CppWinRT.$(PackageVersion).nupkg -NonInteractive -Source https://microsoft.pkgs.visualstudio.com/_packaging/CppWinRT/nuget/v3/index.json -ApiKey VSTS -SkipDuplicate' |
There was a problem hiding this comment.
It's an improvement, but rather than silently omitting packages from the official build just because they collide with a CI build version, let's add a pre-release version to the CI builds. This will remove the collisions so that the official build can always push, and it also clearly denotes the non-official with the pre-release identifier.
I added the code suggestion up above.
Co-authored-by: Ryan Shepherd <ryansh@microsoft.com>
Removed the -SkipDuplicate option from the NuGet push command.
2 participants
Removed Windows pool configuration from build stage, since template job defines the pool.