Sort and unsort the input texts for transformers#66
Open
Conversation
Contributor
Author
|
Without this PR:
With this PR:
Run the below command on GPU-1: |
JiushengChen
reviewed
Dec 3, 2020
Contributor
|
Update doc and benchmark. |
yuyan2do
reviewed
Dec 3, 2020
| the indices in the original input list. | ||
| """ | ||
| is_ascending = -1 if reverse else 1 | ||
| sorted_idx = sorted( |
Contributor
Author
There was a problem hiding this comment.
@yuyan2do Do you mean the benchmarking result on a larger dataset than the data in our benchmark script?
Contributor
There was a problem hiding this comment.
I also have similar worry, as it loaded all data into memory, and then sort. Please check perf on a larger dataset.
Contributor
Author
There was a problem hiding this comment.
Here is the test results on a larger dataset
- 5,242,880 of examples (~ 16GB): sort took ~4.4 seconds; unsort took: 1.4 seconds;
- 15,728,640 of examples (~ 48GB): sort took ~14.0 seconds; unsort took: 4.6 seconds;
yuyan2do
approved these changes
Dec 4, 2020
JiushengChen
approved these changes
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort the input text by their length so that the padding for each batch can be as small as possible.