Remove hard coding of build directory using binaryDir#107
Open
davidhunter22 wants to merge 1 commit intomicrosoft:mainfrom
Open
Remove hard coding of build directory using binaryDir#107davidhunter22 wants to merge 1 commit intomicrosoft:mainfrom
davidhunter22 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
| { | ||
| "name": "ci-build", | ||
| "binaryDir": "${sourceDir}/build", | ||
| "hidden": true |
Collaborator
There was a problem hiding this comment.
If you remove the binaryDir field, then you must update the workflow files to specify the output directory when invoking CMake to configure the build.
Contributor
Author
There was a problem hiding this comment.
I think you should probably reject this PR. I know nothing about workflow files. I can make a attempt to change them but I can't see how to test those changes other than submitting the changes and seeing if they break on your CI and I hate pushing PRs that then break.
I can add "-B ." to all my commands to work around this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106