Focus on InvalidPartitionName's string memory bug#36
Open
menuet wants to merge 1 commit intomicrosoft:mainfrom
Open
Focus on InvalidPartitionName's string memory bug#36menuet wants to merge 1 commit intomicrosoft:mainfrom
menuet wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Collaborator
|
Thank you for the focused test case. I do indeed see that there's an odd lifetime issue here. I believe what I want to suggest is that instead of using I suspect a smallish buffer (say 64 bytes) is sufficient since our longest valid partition offset is currently 39 bytes. If the name is longer than 64 we can truncate it. |
menuet
pushed a commit
to menuet/ifc
that referenced
this pull request
Oct 27, 2023
menuet
pushed a commit
to menuet/ifc
that referenced
this pull request
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I closed inadvertently my previous PR #30, probably because I force-pushed my related branch.
So, I am creating another PR to focus specifically on the memory/life-time issue when catching InvalidPartitionName in translate_exception and accessing the member name.
I hope this can help @cdacamar reproduce/analyze the issue.
(I have put my sample file and added some temporary cmake-stuff to test it easily)