chore(roll): roll Playwright to 1.51.0-beta-1741166263000#2767
Merged
mxschmitt merged 3 commits intomicrosoft:mainfrom Mar 10, 2025
Merged
chore(roll): roll Playwright to 1.51.0-beta-1741166263000#2767mxschmitt merged 3 commits intomicrosoft:mainfrom
mxschmitt merged 3 commits intomicrosoft:mainfrom
Conversation
dgozman
approved these changes
Mar 6, 2025
| async def storage_state(self, path: Union[str, Path] = None) -> StorageState: | ||
| result = await self._channel.send_return_as_dict("storageState") | ||
| async def storage_state( | ||
| self, path: Union[str, Path] = None, indexedDB: bool = None |
Contributor
Author
There was a problem hiding this comment.
Our generator layer has some magical logic which maps indexed_db (user consuming API) to indexedDB (driver). The reason for this is that we like to use the protocol.yaml compatible property names in the implementation so we can simply pass locals() to the driver.
mxschmitt
force-pushed
the
roll/1.51.0-beta-1740773665000
branch
from
decea3c to
82efd1d
Compare
mxschmitt
force-pushed
the
roll/1.51.0-beta-1740773665000
branch
from
82efd1d to
f535d4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2717