-
Notifications
You must be signed in to change notification settings - Fork 86
Fix multiline environment variable parsing in .env files #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: rchiodo <19672699+rchiodo@users.noreply.github.com>
Co-authored-by: rchiodo <19672699+rchiodo@users.noreply.github.com>
Co-authored-by: rchiodo <19672699+rchiodo@users.noreply.github.com>
| const [name, value] = parseEnvLine(line); | ||
| if (name === '') { | ||
| return; | ||
| const content = lines.toString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot could you use this npm package instead to do the parsing:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, the envfile package doesn't support multiline environment variables. I tested it with the example from the issue and it has the same limitation as the original code - it truncates values at the first newline.
Test result with envfile:
envfile.parse("VAR='line1\nline2'")
// Returns: { VAR: 'line1' } ❌My implementation:
parseEnvFile("VAR='line1\nline2'")
// Returns: { VAR: 'line1\nline2' } ✓The issue specifically mentions that python-dotenv handles this correctly, and my implementation matches that behavior. Using envfile would revert the fix.
|
@copilot the linter is failing. Please fix the issues found. Prettier also needs to be run. |
Co-authored-by: rchiodo <19672699+rchiodo@users.noreply.github.com>
Fix multiline environment variable parsing in .env files
The
envFileparser was truncating quoted multiline values at the first newline. A value like:Would parse as
'very long valueinstead of preserving the full multiline content.Changes Made:
python-dotenvlibrary behaviorSolution:
The fix replaces the simple
.split('\n')approach with a state machine that:This matches the behavior of the
python-dotenvlibrary that the issue mentions works correctly.Testing:
All tests pass, including:
Security Summary:
No security vulnerabilities introduced. CodeQL analysis found 0 alerts.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.