Conversation
added 11 commits
February 19, 2016 10:09
This offloads URI escaping of the username and password for HTTP Basic Authentication to RestClient, and sets up the ability to request other authenticated resource URLs directly.
Owner
|
@tuttinator any word on the tests or this PR? |
Author
|
Apologies for neglecting these PRs, which are now probably wildly out of date. Thank you for your work which was immensely valuable when I was working as a data journalist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet ready to merge. Still a work in progress.
This PR will add support for accessing the raw text for individual pages, and does so by refactoring RestClient to use a resource to take advantage of RestClient APIs for HTTP Basic authentication (presumably as HTTP headers under the hood rather than as part of the URL string).
RestClient also escapes characters in the username and password for us.
I've also tried to keep
#pagesas the number of pages, to make sure that API doesn't change.To make this consistent it may require further refactoring in other areas.
This PR will also include tests, possibly after I've finished work on #7