Skip to content

Conversation

@yxdyc
Copy link
Collaborator

@yxdyc yxdyc commented Jan 4, 2026

Improve the contributing.md for more detailed guidance and engagement.

@yxdyc yxdyc requested review from hiyuchang and pan-x-c January 4, 2026 04:19
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yxdyc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the CONTRIBUTING.md file for the Trinity-RFT project. The update transforms the previous brief guide into a comprehensive resource, providing clear instructions and expectations for contributors. It aims to streamline the contribution process by detailing the project's architecture, outlining specific areas for involvement, introducing a "Plugin-First" development approach, and establishing a thorough submission checklist, ultimately fostering more organized and higher-quality contributions.

Highlights

  • Enhanced Contribution Guide: The CONTRIBUTING.md file has been completely revamped to offer a more detailed and structured guide for potential contributors, moving beyond generic instructions.
  • Structured Contribution Areas: A new section outlines specific focus areas within the Trinity-RFT framework, such as Agentic Workflows, RL Algorithms, and Data & Experience, providing clear interfaces and potential tasks.
  • "Plugin-First" Development Workflow: A new workflow is introduced, encouraging contributors to develop features as plugins first, allowing for auto-loading and later integration into the core framework.
  • Comprehensive Submission Checklist: A detailed checklist now guides contributors through the PR submission process, covering registration, testing, code style, and clear description requirements.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a significant improvement to the CONTRIBUTING.md file, making it much more comprehensive and helpful for new contributors. The addition of sections on contribution areas, the 'Plugin-First' approach, and a clear submission checklist are excellent. I have a couple of minor suggestions to further enhance the clarity and consistency of the document.

@pan-x-c pan-x-c merged commit dd72e00 into modelscope:main Jan 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants