fixed No user found then Slack API paginates#197
Open
potapum wants to merge 3 commits intomonzo:masterfrom
Open
fixed No user found then Slack API paginates#197potapum wants to merge 3 commits intomonzo:masterfrom
potapum wants to merge 3 commits intomonzo:masterfrom
Conversation
Added check and additional requests for paginated users.list Slack API call.
fixed wrong combining of lists
fixed infinite loop in pagination
Author
|
Hello @mattrco, |
sebigavril
approved these changes
Jun 17, 2020
sebigavril
left a comment
There was a problem hiding this comment.
Had the same issue. Tested your changes and they fix it.
|
Hi we had the same issue. Would been for you to merge this and it works with ours too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Slack workspace contains more than 1000 user, "users.list" API call response will be paginated. users_list function did not accounted for this. If INCIDENT_BOT_NAME username is not on first page, application will throw