Bug-1948879: Add links to docs and source in the Banner#995
Bug-1948879: Add links to docs and source in the Banner#995moijes12 wants to merge 3 commits intomozilla:mainfrom
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@kala-moz I did run npm run fix-all and the tests run locally. Is there anything I need to do to fix it? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 104 104
Lines 3016 3018 +2
Branches 686 686
=======================================
+ Hits 2907 2909 +2
Misses 108 108
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@moijes12 as julien mentioned in the bug, we should wait for padenot to respond with what he expects to see how we should resolve the bug. |
|
@moijes12 Can we move this out of drafts? Paul has responded to the bug, saying he'll be fine with whatever the team chooses to do. For now, that's putting the link to the docs in the top banner. |
Added links to PerfCompare docs and GitHub source in the Banner.
Update snapshots
|
@kala-moz I am moving this back for review. However, as per discussion on the PerfCompare channel, Greg had asked us to remove the banner completely and place the docs button near the mode toggle button. |
Fix snapshots.
|
@moijes12 I recommend making those changes to remove the banner and add docs under the toggle button to start and we can review the changes with all of that together. |
Added links to docs and source in the Banner by updating
App.tsx.Fixes Bug-1948879