Skip to content

Empty part will hang the process #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ruur wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Empty part will hang the process #25

ruur wants to merge 2 commits into from

Conversation

@ruur
Copy link

@ruur ruur commented Sep 23, 2021

yangh and others added 2 commits September 23, 2021 19:22
@Uzlopak Uzlopak mentioned this pull request Nov 25, 2021
Closed
2 tasks
@kibertoad
Copy link

kibertoad commented Nov 28, 2021

@ruur Are you using dicer as a part of busboy or separately?
Context for the question - we have forked busboy within fastify organization in order to restart development on it, and our original plan was to just embed dicer in it. However, if there is demand for fixed dicer outside of busboy, we can also provide that as a separate dependency.

@ruur
Copy link
Author

ruur commented Dec 2, 2021

@ruur ruur closed this Dec 2, 2021
@ruur ruur reopened this Dec 2, 2021
@ruur
Copy link
Author

ruur commented Dec 2, 2021

@kibertoad yes, I used dicer as a part of busboy

maxpoulin64 added a commit to maxpoulin64/thelounge that referenced this pull request Dec 5, 2021
@maxpoulin64
Switch busboy implementation to @fastify/busboy
2c2dd1c 
I've been notified the current implementation is abandonned and has been forked by fastify to fix bugs, including some crashes and hangs:
See:
* mscdex/busboy#250
* mscdex/dicer#22
* mscdex/dicer#25
@maxpoulin64 maxpoulin64 mentioned this pull request Dec 5, 2021
Merged
@kibertoad
Copy link

kibertoad commented Dec 5, 2021

This was fixed in https://github.com/fastify/busboy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ruur @kibertoad