specify filename in UploadFileToControllerViaForm#107
Draft
cielavenir wants to merge 2 commits intomasterfrom
Draft
specify filename in UploadFileToControllerViaForm#107cielavenir wants to merge 2 commits intomasterfrom
cielavenir wants to merge 2 commits intomasterfrom
Conversation
ziyan
reviewed
Apr 30, 2022
Member
|
@cielavenir do we have to worry about back compat with existing users? |
Contributor
Author
master uploadFileNameInURI This means previously (without uploadFileNameInURI) uploaded file could not be accessed. |
Contributor
Author
|
Or do you mean this works (currently) and some users might do this weird convertion? [edit] if no, I don't think of other worries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #79