Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add an option to delete a secret from the store.
As the user can freely create secrets, he doesn't have any option to delete them in case of mistake.
He also doesn't have any way to update credentials. This PR bring at least a way to delete the secret and recreate it if he needs to.
As we need to remove the secret key completely, we need to perform a http DELETE on the
secret/metadata/path.So the user need to have this policy rule :
@mulbc while reviewing this one, you might not see the delete icon as I added
fill="currentColor"on the svg file, the same way I added this attribute on the copy-username and copy-password icons in #64 . When those 2 PR will be merged, the icons should be all fine.