Skip to content

Feat: add a Delete secret button#67

Open
Raphyyy wants to merge 1 commit intomulbc:masterfrom
Raphyyy:feat/add-delete-btn
Open

Feat: add a Delete secret button#67
Raphyyy wants to merge 1 commit intomulbc:masterfrom
Raphyyy:feat/add-delete-btn

Conversation

@Raphyyy
Copy link

@Raphyyy Raphyyy commented Feb 6, 2026

This PR add an option to delete a secret from the store.
As the user can freely create secrets, he doesn't have any option to delete them in case of mistake.
He also doesn't have any way to update credentials. This PR bring at least a way to delete the secret and recreate it if he needs to.

image

As we need to remove the secret key completely, we need to perform a http DELETE on the secret/metadata/ path.
So the user need to have this policy rule :

path "secret/metadata/vaultPass/{storePath}/" {
  capabilities = ["delete"]
}

@mulbc while reviewing this one, you might not see the delete icon as I added fill="currentColor" on the svg file, the same way I added this attribute on the copy-username and copy-password icons in #64 . When those 2 PR will be merged, the icons should be all fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant