-
Notifications
You must be signed in to change notification settings - Fork 176
feat(expr-ir): Support DataFrame.pivot
#3373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+880
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pivot` will need to check from `options` and either `dataframe`, `functions`, or `group_by`
Still needs a lot of work, but it is definitely possible
dangotbanned
commented
Dec 28, 2025
dangotbanned
commented
Dec 28, 2025
dangotbanned
commented
Dec 28, 2025
dangotbanned
commented
Dec 28, 2025
dangotbanned
commented
Dec 28, 2025
Found some more errors on the rust-side Probably gonna rewrite this to avoid checking all the paths this exhaustively
Working on a repro, have found this doesn't trigger any exotic paths
- Leaving `Selector`s out for now - but `list[str]` was much narrower than what is already supported
`mypy` wasn't happy with the typing after I switched to `chain` - so no need point in #3373 (comment)
This was referenced Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chapter 6 gets us closer to the recently-introduced
DslPlan::Pivot.But you're probably reading this because the PR finally adds support for
pivotonpyarrow>=20😄Important
This was a pretty complicated one
After I figured out how
pyarrow.compute.pivot_widerworked, I discovered it didn't natively support:aggregate_functiononcolumnsSo ... after quite a journey, I've got those working too 🥳
Related issues
pivotto Arrow #2179ExprIR #2572concat#3371hash_pivot_widerapache/arrow#48679