Improve Type Safety in http-agent #7902
Conversation
Refactored `src/lib/http-agent.ts` to improve type safety and remove `@ts-expect-error` suppressions. - Replaced the custom `HttpsProxyAgentWithCA` class with the correct usage of the `https-proxy-agent` library. - Improved function signatures and return types using discriminated unions (`Success | Failure`) for safer and more predictable code. - Updated the call-site in `src/commands/base-command.ts` to correctly handle the `HttpsProxyAgent` type. - Aligned the unit tests in `tests/unit/lib/http-agent.test.ts` with the new implementation. Co-authored-by: serhalp <1377702+serhalp@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This submission improves the type safety of the
http-agentmodule by removing a custom, error-prone class and replacing it with the correct, modern usage of thehttps-proxy-agentlibrary. The changes include refactoring function signatures, using discriminated unions for return types, and updating call-sites and tests to align with the new implementation.PR created automatically by Jules for task 6124655028326514442 started by @serhalp