Open
Conversation
Only the things that were removed from there
Member
|
The functions are useful and so, but, as there is no use case (so far) in icaros, does it make sense to add those functions with no usage? |
Collaborator
Author
|
It's just to not lose them. As far as I am concerned they can be left as an open PR without merging them into the repo. |
mmkekic
added a commit
to mmkekic/ICAROS
that referenced
this pull request
Apr 14, 2020
mmkekic
added a commit
to mmkekic/ICAROS
that referenced
this pull request
Apr 14, 2020
Related to PR next-exp#42
mmkekic
added a commit
to mmkekic/ICAROS
that referenced
this pull request
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following next-exp/IC#707, I add here the stuff that has been removed from IC and may still be of interest to someone.