Skip to content

feat(assistant): translate task type #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alperozturk96 wants to merge 12 commits into
base: master
Choose a base branch
from
Open

feat(assistant): translate task type #1933

alperozturk96 wants to merge 12 commits into from

Conversation

@alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented Jan 20, 2026 •
edited
Loading

Adds translation task type
Uses kotlinx.serialization instead of gson. for more detail: https://github.com/nextcloud/android-library/pull/1836/changes#r2625981939

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2525
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total167167

@codecov
Copy link

codecov bot commented Jan 20, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 23.07692% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...id/lib/resources/assistant/v2/model/Translation.kt 0.00% 27 Missing ⚠️
...roid/lib/resources/assistant/v2/model/TaskTypes.kt 72.72% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2525
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total167167

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2525
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total167167

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2525
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total167167

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2525
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total167167

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2525
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total167167

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2525
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total167167

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jan 21, 2026

master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4873-IT-master-15-19/debug/

@alperozturk96 alperozturk96 removed the request for review from tobiasKaminsky January 22, 2026 15:03
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2525
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total167167

@alperozturk96
feat(assistant): translate task type
039b9a7 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add translation model
91ca973 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use org.jetbrains.kotlinx:kotlinx-serialization-json
787c165 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use org.jetbrains.kotlinx:kotlinx-serialization-json
0913617 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use org.jetbrains.kotlinx:kotlinx-serialization-json
2e9bb9d 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use org.jetbrains.kotlinx:kotlinx-serialization-json
1e4f7e1 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use org.jetbrains.kotlinx:kotlinx-serialization-json
7ba4e84 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use org.jetbrains.kotlinx:kotlinx-serialization-json
fb7374d 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use org.jetbrains.kotlinx:kotlinx-serialization-json
d468602 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix tests
353b876 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix tests
be6aa57 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix tests
0752f97 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the feat/translation-task-type branch from 91f2261 to 0752f97 Compare January 23, 2026 14:30
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2525
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total167167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2. developing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alperozturk96 @nextcloud-android-bot